Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatically focus the first row/panel/key on first render and after making selections #5770

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

kshen0
Copy link
Contributor

@kshen0 kshen0 commented Dec 18, 2024

Overview

Small QOL change for the switch scanning keyboard for write-ins

  • Focus the first row when the keyboard is first rendered
  • After a row/panel/key is selected, focus the first child
    • Row selected -> focus first panel
    • Panel selected -> focus first key

Demo Video or Screenshot

scan-panel-write-ins-autofocus.mov

Testing Plan

Updated existing tab/enter test to expect focus without tabbing

Checklist

  • I have added logging where appropriate to any new user actions, system updates such as file reads or storage writes, or errors introduced.
  • I have added a screenshot and/or video to this PR to demo the change
  • I have added the "user_facing_change" label to this PR to automate an announcement in #machine-product-updates

@kshen0 kshen0 requested a review from kofi-q December 18, 2024 22:20
Copy link
Contributor

@kofi-q kofi-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@kshen0 kshen0 merged commit 3e62083 into main Dec 18, 2024
62 checks passed
@kshen0 kshen0 deleted the kevin/vxmark-switch-scanning-focus-polish branch December 18, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants