test(logging): replace jest with vitest
#5765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahkagan
approved these changes
Dec 17, 2024
libs/logging/package.json
Outdated
| "test:ci": "pnpm build && pnpm test:coverage --reporters=default --reporters=jest-junit --maxWorkers=6 && pnpm build:generate-typescript-types --check && pnpm build:generate-rust-types --check", | ||
| "test:watch": "TZ=UTC vitest", | ||
| "test:coverage": "TZ=UTC vitest --coverage", | ||
| "test:ci": "pnpm build && TZ=UTC vitest run --coverage && pnpm build:generate-typescript-types --check && pnpm build:generate-rust-types --check", |
There was a problem hiding this comment.
Maybe a good time to switch to America/Anchorage timezone?
I'm guessing that eventually vitest will either use a new enough version of esbuild or switch to oxc (where hopefully they'll have a solution to this). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5725
In addition to changing the tests for
libs/loggingitself, changesmockLoggeret al to require a mock function. Some of theistanbul ignoredirectives no longer work becauseesbuildat the versionvitestuses doesn't support preserving comments preceding acaseordefault(see this).