Migrate Famous Names election fixture to have grid layouts / strings generated #5743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolinemodic
force-pushed
the
caro/migrate_famous_names
branch
from
7222abf to
83e0a5e
Compare
carolinemodic
requested review from
jonahkagan and
eventualbuddha
as code owners
jonahkagan
approved these changes
Dec 12, 2024
| @@ -9,8 +9,10 @@ export NODE_ENV=development | |||
| # Check if FORCE_RETRANSLATE is set to true | |||
| if [ -z "$FORCE_RETRANSLATE" ]; then | |||
There was a problem hiding this comment.
Nit: This comment is a little confusing since this is actually checking if FORCE_RETRANSLATE is unset, right?
carolinemodic
force-pushed
the
caro/migrate_election_primary_precinct_split
branch
from
c0530b3 to
5ce9b08
Compare
Base automatically changed from
caro/migrate_election_primary_precinct_split
to
main
December 12, 2024 23:35
carolinemodic
force-pushed
the
caro/migrate_famous_names
branch
from
83e0a5e to
80f87e4
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Depends on #5732
Next step of cleaning up election fixtures, migrates famous names to generate an election with strings & grid layouts and use that across tests. toElectionPackage was already not exported for this election. I am leaving this election as single-language for now, there are many tests that use a random single language election to test single language behavior and I don't want to disrupt that so I'm going to leave everything how it currently exists in terms of single/multi language for now and then when everything is migrated consider if some of the single language fixtures should change to be multi language.
Testing Plan
Ran Tests