Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(mark-flow-ui): replace jest with vitest #5719

Merged
merged 2 commits into from
Dec 11, 2024
Merged

test(mark-flow-ui): replace jest with vitest #5719

merged 2 commits into from
Dec 11, 2024

Conversation

jonahkagan
Copy link
Collaborator

Overview

Closes #5715

Demo Video or Screenshot

N/A

Testing Plan

Automated tests

Checklist

  • I have added logging where appropriate to any new user actions, system updates such as file reads or storage writes, or errors introduced.
  • I have added a screenshot and/or video to this PR to demo the change
  • I have added the "user_facing_change" label to this PR to automate an announcement in #machine-product-updates

@jonahkagan jonahkagan force-pushed the brian/test/mark-flow-ui/vitest branch from 391baa1 to b201fc6 Compare December 10, 2024 23:00
@jonahkagan jonahkagan changed the base branch from main to vitest December 10, 2024 23:01
@jonahkagan jonahkagan force-pushed the brian/test/mark-flow-ui/vitest branch 4 times, most recently from ce7a9a2 to baa2ef5 Compare December 10, 2024 23:12
@jonahkagan jonahkagan marked this pull request as ready for review December 10, 2024 23:16
@jonahkagan jonahkagan force-pushed the brian/test/mark-flow-ui/vitest branch 3 times, most recently from cf2b16c to f890cba Compare December 11, 2024 00:02
@jonahkagan jonahkagan force-pushed the brian/test/mark-flow-ui/vitest branch from f890cba to 6b763f7 Compare December 11, 2024 17:46
eventualbuddha
eventualbuddha approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@eventualbuddha eventualbuddha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay for tackling one of the more gnarly UI-based packages!

@jonahkagan jonahkagan merged commit e9904fe into vitest Dec 11, 2024
62 checks passed
@jonahkagan jonahkagan deleted the brian/test/mark-flow-ui/vitest branch December 11, 2024 18:04
eventualbuddha pushed a commit that referenced this pull request Dec 12, 2024
@jonahkagan @eventualbuddha
test(mark-flow-ui): replace jest with vitest (#5719)
dd91946
eventualbuddha pushed a commit that referenced this pull request Dec 19, 2024
@jonahkagan @eventualbuddha
test(mark-flow-ui): replace jest with vitest (#5719)
fa5444f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eventualbuddha eventualbuddha eventualbuddha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

libs/mark-flow-ui
2 participants
@jonahkagan @eventualbuddha