test(ballot-interpreter): switch from jest to vitest
#5705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eventualbuddha
changed the title
jest to vitest
jonahkagan
approved these changes
Dec 10, 2024
This doesn't actually update the test files yet, so everything is failing.
Making `./addon` a TypeScript module means we can easily mock it.
eventualbuddha
force-pushed
the
brian/test/ballot-interpreter/vitest
branch
from
f0d1834 to
0e3a2b7
Compare
We want to build on top of the `vitest` version.
- convert `ballot-interpreter` benchmarks to `vitest`
- convert `test-utils-vitest` to `type: module` so that the built version is ESM; this is needed because you're not allowed to `require('vitest')`
- run `ballot-interpreter` tests as modules by renaming to `.mts`
Was getting this in CI: ``` RangeError: options.minThreads and options.maxThreads must not conflict ❯ new Tinypool ../../node_modules/.pnpm/[email protected]/node_modules/tinypool/dist/index.js:980:13 ❯ createForksPool ../../node_modules/.pnpm/[email protected]_@[email protected]/node_modules/vitest/dist/chunks/resolveConfig.RxKrDli4.js:6755:16 ❯ forks ../../node_modules/.pnpm/[email protected]_@[email protected]/node_modules/vitest/dist/chunks/resolveConfig.RxKrDli4.js:7663:20 ```
eventualbuddha
added a commit
that referenced
this pull request
Dec 11, 2024
eventualbuddha
added a commit
that referenced
this pull request
Dec 11, 2024
eventualbuddha
added a commit
that referenced
this pull request
Dec 12, 2024
eventualbuddha
added a commit
that referenced
this pull request
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #5708
Switch from
jesttovitestinlibs/ballot-interpreter.Demo Video or Screenshot
n/a
Testing Plan
Automated.