-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pdi-scanner): use a smaller USB buffer in development #5551
Merged
eventualbuddha
merged 1 commit into
main
from
5541-toggle-pdi-buffer-size-given-node_env-so-that-dev-works-out-the-box
Oct 24, 2024
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
fn main() { | ||
println!("cargo::rustc-check-cfg=cfg(production)"); | ||
println!("cargo:rerun-if-env-changed=NODE_ENV"); | ||
|
||
let is_production = match std::env::var("NODE_ENV") { | ||
Ok(env) => env == "production", | ||
Err(_) => false, | ||
}; | ||
|
||
if is_production { | ||
println!("cargo:rustc-cfg=production"); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing I'm unsure about is whether we also need to consider whether this is a VxDev setup vs. true prod. On VxDev,
NODE_ENV
isproduction
, butREACT_APP_VX_DEV
is set totrue
so that we can distinguish it from true prod, e.g.vxsuite/libs/auth/src/config.ts
Lines 24 to 26 in 0d0e272
My quick sense is that, since VxDev isn't using VMs, it doesn't need the smaller buffer.
So all probably fine as is, just wanted to flag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do the simpler version to start. If it turns out VxDev doesn't work, we can update it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup sounds right to me!