Update log export filenames to use locale timestamps instead of UTC #5548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kofi-q
requested review from
a team,
carolinemodic and
eventualbuddha
and removed request for
a team and
carolinemodic
eventualbuddha
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #5346
To avoid user confusion, this updates filenames on log export directories to reflect the date/time in the locale of the machine they were saved from, instead of using the UTC date/time, which might not match the day of the election at first glance.
Initially went with a format that included the timezone code at the end, but later found the utility used for our CVR exports, so just using that to be consistent.
Demo Video or Screenshot
Testing Plan
Checklist
[ ] I have added logging where appropriate to any new user actions, system updates such as file reads or storage writes, or errors introduced.[ ] I have added a screenshot and/or video to this PR to demo the change