Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BMD] Provide clearer audio feedback after using all votes in a contest #5547

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

kofi-q
Copy link
Contributor

@kofi-q kofi-q commented Oct 23, 2024

Overview

Closes #5315

When voters make a selection, we play audio reading out the number of remaining votes.
This updates that audio when the final available selection in a contest is made, to make it clearer that the voter can advance to the next contest.

Demo Video or Screenshot [ 🔊 ]

2024-10-23.11-44-52.mov

Testing Plan

  • Unit tests and manual verification with generated audio

Checklist

  • [ ] I have added logging where appropriate to any new user actions, system updates such as file reads or storage writes, or errors introduced.
  • I have added a screenshot and/or video to this PR to demo the change
  • I have added the "user_facing_change" label to this PR to automate an announcement in #machine-product-updates

@kofi-q kofi-q requested review from a team and jonahkagan and removed request for a team October 23, 2024 17:43
@kofi-q
Copy link
Contributor Author

kofi-q commented Oct 23, 2024

cc @mattroe as FYI/for optional product review

@kofi-q kofi-q requested review from nikhilb4a and removed request for jonahkagan October 23, 2024 17:52
Copy link
Contributor

@nikhilb4a nikhilb4a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kofi-q kofi-q merged commit 4ed2678 into main Oct 23, 2024
62 checks passed
@kofi-q kofi-q deleted the 5315-audio-prompt-on-contest-completion branch October 23, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VxMark: Prompt ATI user that they have made max number of selections and can navigate to next contest
2 participants