mark-scan: Instructions for early ballot removal #4681
Conversation
kshen0
force-pushed
the
kevin/instructions-for-early-ballot-removal
branch
from
e5a2835 to
952eaa8
Compare
kshen0
changed the title
kshen0
force-pushed
the
kevin/instructions-for-early-ballot-removal
branch
from
952eaa8 to
0c02a6b
Compare
| @@ -1 +0,0 @@ | |||
| ./build/assets/index.c1222e2b.js:31135 | |||
There was a problem hiding this comment.
codemod util file that was previously committed by accident
kshen0
force-pushed
the
kevin/instructions-for-early-ballot-removal
branch
2 times, most recently
from
0d43332 to
8fc83c1
Compare
kshen0
force-pushed
the
kevin/instructions-for-early-ballot-removal
branch
from
8fc83c1 to
1798ba2
Compare
| // move auth entirely to the backend. | ||
| // https://github.com/votingworks/vxsuite/issues/3985 | ||
| stateMachineState !== 'accepting_paper' && | ||
| stateMachineState !== 'not_accepting_paper' |
There was a problem hiding this comment.
Now that we've seen this is a consistent pattern for any state that changes auth in the backend, IMO we should bump the priority of #3985 ahead of adding any additional states with auth changes @arsalansufi @jonahkagan @mattroe
There was a problem hiding this comment.
That makes sense! I brought the issue up to the medium pri section on the VxMarkScan board. (I don't have a great sense of which issues would require "adding any additional states with auth changes")
| @@ -283,6 +296,45 @@ test('voting flow happy path', async () => { | |||
| await waitForStatus('not_accepting_paper'); | |||
| }); | |||
|
|
|||
| describe('removing ballot during presentation state', () => { | |||
| test('is a no op if USE_MOCK_PAPER_HANDLER=true', async () => { | |||
There was a problem hiding this comment.
Need this to no-op because we detect ballot removal when the NO_PAPER_ANYWHERE event is fired, and paper handler status always reports NO_PAPER_ANYWHERE when using mock paper handler.
Overview
#4542
Gives instructions to the voter when the ballot is removed during the presentation stage. On mark-scan the ideal path is for the voter to use the interface to confirm their ballot is correct, which causes the app to pull the paper back in and cast it to the rear box. But it's likely that some voters will remove the ballot during the presentation stage, especially if they realize other voters are casting their HMPBs at a precinct scanner.
In the case of early removal we should give instructions to cast at a precinct scanner rather than just ending the session.
Demo Video or Screenshot
Changes start at 0:20
IMG_4800.MOV
Testing Plan
Checklist