VxDesign: Fix bug for primary elections #4400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a well-intentioned assertion guarding against an edge case in primary elections where there were no partisan contests (which would result in no ballot styles being generated). The intention was to explain to the user why there were no ballot styles in that case. However, crashing the app until partisan contests are added prevents the user from being able to address the issue, so it was not a good solution.
jonahkagan
requested review from
arsalansufi and
eventualbuddha
and removed request for
arsalansufi
eventualbuddha
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes: #4063
There was a well-intentioned assertion guarding against an edge case in primary elections where there were no partisan contests (which would result in no ballot styles being generated). The intention was to explain to the user why there were no ballot styles in that case. However, crashing the app until partisan contests are added prevents the user from being able to address the issue, so it was not a good solution.
Demo Video or Screenshot
N/A
Testing Plan
Manual test
Checklist