Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve WIA Cropping #4223

Merged
merged 5 commits into from
Nov 16, 2023
Merged

Improve WIA Cropping #4223

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
629b2d9
update VxHMPB option bounds
adghayes Nov 16, 2023
c68ae73
update fixtures - does this look right?
adghayes Nov 16, 2023
435f300
correct README
adghayes Nov 16, 2023
6bdb2d2
update libs/types fixtures for completeness
adghayes Nov 16, 2023
5f4e3eb
interpreter tweak
adghayes Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libs/hmpb/layout/src/layout.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1687,7 +1687,7 @@ function layOutBallotHelper({
bottom: 1,
left: 1,
right: 9,
top: 2,
top: 1,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were cropping a little high on the VxBallots, see difference between highlight and desired area:

Screen Shot 2023-11-13 at 4 42 13 PM

The cropping too low is dealt with in the interpreter. The above is correct - it says 1 and we want 1. That off-by-one issue is in the interpreter.

},
gridPositions,
},
Expand Down