feat(ui): allow variable-length PINs #4083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VxSuite PINs are still always 6 digits. RAVE PINs are variable, and this is ported from RAVE since it may be useful in the future here and will make RAVE rebases easier.
eventualbuddha
force-pushed
the
brian/feat/ui/variable-pin-length
branch
from
113bd5c to
2bae652
Compare
kshen0
approved these changes
Oct 11, 2023
| private readonly maximum: number | ||
| ) { | ||
| assert(minimum > 0, 'min must be > 0'); | ||
| assert(minimum <= maximum, 'min must be <= max'); |
There was a problem hiding this comment.
Is there a maximum where the UI breaks down?
There was a problem hiding this comment.
I'm guessing it wouldn't make sense beyond ~20 depending on the container width, but I'm inclined to leave that to be unrestricted here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
VxSuite PINs are still always 6 digits. RAVE PINs are variable, and this is ported from RAVE since it may be useful in the future here and will make RAVE rebases easier.
Demo Video or Screenshot
Testing Plan