Manual Tally Policy - CSV Tally Reports

libs/utils/src/tabulation/tabulation.test.ts

@@ -1,5 +1,6 @@
 import {
   electionFamousNames2021Fixtures,
+  electionTwoPartyPrimary,
   electionTwoPartyPrimaryDefinition,
   electionTwoPartyPrimaryFixtures,
 } from '@votingworks/fixtures';
@@ -11,6 +12,7 @@ import {
   YesNoContest,
   safeParseJson,
   CastVoteRecordExportFileName,
+  CandidateContest,
 } from '@votingworks/types';
 import { readFileSync } from 'fs';
 import { join } from 'path';
@@ -37,6 +39,8 @@ import {
   getSheetCount,
   getScannedBallotCount,
   getHmpbBallotCount,
+  combineCandidateContestResults,
+  buildContestResultsFixture,
 } from './tabulation';
 import {
   convertCastVoteRecordVotesToTabulationVotes,
@@ -1265,3 +1269,56 @@ test('mergeManualWriteInTallies', () => {
     })
   );
 });
+
+test('combinedCandidateContestResults - does not alter original tallies', () => {
+  const contest = find(
+    electionTwoPartyPrimary.contests,
+    (c) => c.id === 'zoo-council-mammal'
+  ) as CandidateContest;
+  const contestResultsA = buildContestResultsFixture({
+    contest,
+    contestResultsSummary: {
+      type: 'candidate',
+      ballots: 50,
+      writeInOptionTallies: {
+        'write-in-1': {
+          name: 'Write-In 1',
+          tally: 10,
+        },
+        'write-in-2': {
+          name: 'Write-In 2',
+          tally: 40,
+        },
+      },
+    },
+  }) as Tabulation.CandidateContestResults;
+
+  const contestResultsB = buildContestResultsFixture({
+    contest,
+    contestResultsSummary: {
+      type: 'candidate',
+      ballots: 50,
+      writeInOptionTallies: {
+        'write-in-1': {
+          name: 'Write-In 1',
+          tally: 20,
+        },
+        'write-in-3': {
+          name: 'Write-In 3',
+          tally: 30,
+        },
+      },
+    },
+  }) as Tabulation.CandidateContestResults;
+
+  const aString = JSON.stringify(contestResultsA);
+  const bString = JSON.stringify(contestResultsB);
+
+  combineCandidateContestResults({
+    contest,
+    allContestResults: [contestResultsA, contestResultsB],
+  });
+
+  expect(JSON.stringify(contestResultsA)).toEqual(aString);
+  expect(JSON.stringify(contestResultsB)).toEqual(bString);
+});

libs/utils/src/tabulation/tabulation.ts

@@ -541,7 +541,9 @@ export function combineCandidateContestResults({
         combinedContestResults.tallies[candidateTally.id];
 
       if (!combinedCandidateTally) {
-        combinedContestResults.tallies[candidateTally.id] = candidateTally;
+        combinedContestResults.tallies[candidateTally.id] = {
+          ...candidateTally,
+        };
       } else {
         combinedCandidateTally.tally += candidateTally.tally;
       }