fix(auth): do more validation of TLV messages #4064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were not validating: - that the encoded tag is the one we expected - that the first length byte is ≤ 0x80 if it isn't one of the special 0x81 or 0x82 values - that the TLV response didn't contain more data than the length said it should
eventualbuddha
requested review from
carolinemodic
and removed request for
a team
arsalansufi
reviewed
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We were not validating:
See Slack discussion.
Demo Video or Screenshot
n/a
Testing Plan
Automated, manually tested that programming a sysadmin card and using it in VxScan still works.