Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s/MARK_WORKSPACE/MARK_SCAN_WORKSPACE #4060

Merged
merged 2 commits into from
Oct 10, 2023
Merged

s/MARK_WORKSPACE/MARK_SCAN_WORKSPACE #4060

merged 2 commits into from
Oct 10, 2023

Conversation

kshen0
Copy link
Contributor

@kshen0 kshen0 commented Oct 9, 2023

Overview

Replaces the env var MARK_WORKSPACE with MARK_SCAN_WORKSPACE in VxMarkScan.

Demo Video or Screenshot

N/A

Testing Plan

Built and ran locally

Checklist

  • I have added logging where appropriate to any new user actions, system updates such as file reads or storage writes, or errors introduced. (N/A)

@kshen0 kshen0 mentioned this pull request Oct 9, 2023
Merged
@kshen0 kshen0 marked this pull request as ready for review October 9, 2023 21:18
@kshen0 kshen0 requested a review from a team as a code owner October 9, 2023 21:18
@kshen0 kshen0 requested review from arsalansufi and removed request for a team and arsalansufi October 9, 2023 21:18
@kshen0
Copy link
Contributor Author

kshen0 commented Oct 9, 2023

@arsalansufi I'm explicitly assigning you since you were rolled from vxsuite-eng and this PR has minimal context!

arsalansufi
arsalansufi approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@arsalansufi arsalansufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kshen0 kshen0 merged commit 021f5ea into main Oct 10, 2023
@kshen0 kshen0 deleted the kevin/fix-vxmarkscan-workspace branch October 10, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arsalansufi arsalansufi arsalansufi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kshen0 @arsalansufi