Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kevin/polish rear eject #4049

Merged
merged 5 commits into from
Oct 12, 2023
Merged

Kevin/polish rear eject #4049

merged 5 commits into from
Oct 12, 2023

Conversation

kshen0
Copy link
Contributor

@kshen0 kshen0 commented Oct 6, 2023 •
edited
Loading

Overview

#3945
#3971

  • Fixes a bug where a jam would be triggered on rear eject too early
  • Adds a screen shown when the ballot is being cast, which fixes a bug where the "Printing ballot" screen is shown when casting the ballot
  • Removes the post-voting instructions. These were left over from VxMark and are not relevant for MarkScan's ballot cast flow.

Demo Video or Screenshot

IMG_4310.MOV

Testing Plan

  • Update existing frontend tests to check for new screen header

Checklist

  • I have added logging where appropriate to any new user actions, system updates such as file reads or storage writes, or errors introduced. (No user actions)
  • I have added a screenshot and/or video to this PR to demo the change
  • I have added the "user_facing_change" label to this PR to automate an announcement in #machine-product-updates

@kshen0 kshen0 force-pushed the kevin/polish-rear-eject branch 2 times, most recently from 24bfc21 to d2ac466 Compare October 10, 2023 22:19
@kshen0 kshen0 marked this pull request as ready for review October 10, 2023 22:28
@kshen0 kshen0 requested a review from a team as a code owner October 10, 2023 22:28
@kshen0 kshen0 requested review from eventualbuddha and jonahkagan and removed request for a team and eventualbuddha October 10, 2023 22:28
jonahkagan
jonahkagan approved these changes Oct 11, 2023
View reviewed changes
apps/mark-scan/frontend/src/pages/casting_ballot_page.tsx Outdated
<Text center>
<ProgressBar duration={4000} />
<H1>Casting Your Official Ballot...</H1>
</Text>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree the ellipsis looks weird. It seems unnecessary to animate the ellipsis since there's already another animation happening. I think one animation at a time is a good visual rule of thumb.

apps/mark-scan/frontend/src/app_root.tsx Outdated
stateMachineState === 'ejecting_to_rear' ||
stateMachineState === 'resetting_state_machine_after_success' ||
// Cardless voter auth is ended in the backend when the voting session ends but the frontend
// may have a stale value. Cardless voter auth + 'not_accepting_paper' state means the fronend
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: fronend -> frontend

@kshen0 kshen0 force-pushed the kevin/polish-rear-eject branch from cf82143 to a91f4d9 Compare October 11, 2023 23:18
@kshen0 kshen0 force-pushed the kevin/polish-rear-eject branch 2 times, most recently from 9c7e480 to ce51a5e Compare October 11, 2023 23:35
@kshen0 kshen0 force-pushed the kevin/polish-rear-eject branch from a72db4f to b28f805 Compare October 12, 2023 00:05
@kshen0 kshen0 merged commit d942a51 into main Oct 12, 2023
@kshen0 kshen0 deleted the kevin/polish-rear-eject branch October 12, 2023 00:14
This was referenced Nov 17, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahkagan jonahkagan jonahkagan approved these changes

Assignees
No one assigned
Labels
user_facing_change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kshen0 @jonahkagan