refactor(auth): make Buffer
use more idiomatic
#4041
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We don't need the
numericArray
helper or spreading into array literals passed toBuffer.from
calls. Instead, we should use the more idiomatic and efficientBuffer.alloc
andBuffer.concat
calls. This also changesBuffer.from([…])
calls toBuffer.of(…)
as the intermediate array is just extra noise (they probably amount to about the same in terms of perf for small N, at any rate).Demo Video or Screenshot
n/a
Testing Plan
Automated