Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admin): Ballot Count Report Builder #4019

Merged
merged 15 commits into from
Oct 4, 2023
Merged

feat(admin): Ballot Count Report Builder #4019

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
da6714c
update filter and group by components to allow using Party as a dimen…
adghayes Oct 3, 2023
6a447c5
change tally report print logging
adghayes Oct 3, 2023
ece2502
refactor: update export report PDF button to allow supporting ballot …
adghayes Oct 3, 2023
c056bf9
refactor: rename tally report csv button to be consistent with backen…
adghayes Oct 3, 2023
d2bff38
renaming: rename button from 'Export CSV Results' to 'Export Report C…
adghayes Oct 3, 2023
4756f58
add title and filename generating utils for ballot count reports
adghayes Oct 3, 2023
4c397fe
add component to export ballot count report CSV from backend, akin to…
adghayes Oct 3, 2023
47d18e8
deprecate old test util for mocking the card counts endpoint
adghayes Oct 3, 2023
bff4a0a
ui: add subtitle to ballot count reports
adghayes Oct 3, 2023
fe88fa9
add ballot count report viewer component
adghayes Oct 3, 2023
887a18c
add ballot count report builder screen
adghayes Oct 3, 2023
996ff2b
routing: add link to ballot count report builder to reports screen
adghayes Oct 3, 2023
c9d412b
add report names for party reports, and testing
adghayes Oct 3, 2023
45ded8d
use party short name instead of abbreviation in ballot count reports,…
adghayes Oct 3, 2023
69003aa
test coverage tiny tweak
adghayes Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions apps/admin/frontend/src/components/reporting/tally_report_viewer.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,9 @@ test('print after preview loaded + test success logging', async () => {
'election_manager',
{
disposition: 'success',
message: 'User printed a custom tally report from the report builder.',
message: 'User printed a tally report.',
filter: '{}',
groupBy: '{}',
}
);
});
Expand Down Expand Up @@ -277,7 +279,9 @@ test('print failure logging', async () => {
{
disposition: 'failure',
message:
'User attempted to print a custom tally report from the report builder, but an error occurred: printer broken',
'User attempted to print a tally report, but an error occurred: printer broken',
filter: '{}',
groupBy: '{}',
}
);
});
Expand Down
10 changes: 8 additions & 2 deletions apps/admin/frontend/src/components/reporting/tally_report_viewer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,17 +252,23 @@ export function TallyReportViewer({
);

setProgressModalText('Printing Report');
const reportProperties = {
filter: JSON.stringify(filter),
groupBy: JSON.stringify(groupBy),
} as const;
Comment on lines +256 to +259
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a brute force approach to adding information in logging, but I think it's valuable to include this information and, due to the infrequency with which logs will be looked at, not worth investing time in something prettier.

try {
await printElement(reportToPrint, { sides: 'one-sided' });
await logger.log(LogEventId.TallyReportPrinted, userRole, {
message: `User printed a custom tally report from the report builder.`,
message: `User printed a tally report.`,
disposition: 'success',
...reportProperties,
});
} catch (error) {
assert(error instanceof Error);
await logger.log(LogEventId.TallyReportPrinted, userRole, {
message: `User attempted to print a custom tally report from the report builder, but an error occurred: ${error.message}`,
message: `User attempted to print a tally report, but an error occurred: ${error.message}`,
disposition: 'failure',
...reportProperties,
});
} finally {
setProgressModalText(undefined);
Expand Down