Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trusted Build changes #4001

Merged
merged 16 commits into from
Oct 2, 2023
Merged

Trusted Build changes #4001

merged 16 commits into from
Oct 2, 2023

Conversation

amcmanus
Copy link
Contributor

This PR includes all the changes necessary to support Trusted Builds of VotingWorks applications. Due to the unique requirements of that process, vxsuite no longer performs installation of system level tools/frameworks.

Makefiles and apt packages:

  • We no longer install packages via Makefiles. This functionality has been moved to vxsuite-build-system
  • When necessary, Makefiles were updated to continue to support the bootstrap script for ease of use

Rust:

  • Rust install and build commands (invoked via pnpm) are now explicitly separate. Install is only responsible for fetching cargo crates, and build is responsible for the actual compilation. This is necessary for Trusted Build
  • pnpm configuration has been changed to only run Rust as needed (it ran by default previously)
  • CircleCI has been updated to support this new build approach

Python / converter-ms-sems:

  • In an effort to remove python/pip dependencies from vxsuite, converter-ms-sems has been disabled during any build processes. It will eventually be removed/rewritten, but that is outside the scope of this PR.

Since CircleCI has also been updated to support these changes, running the test suite serves as the initial test of these changes. Additionally, extensive testing of the build process has been performed as part of the vxsuite-build-system Trusted Build effort.

@amcmanus amcmanus requested review from arsalansufi and a team as code owners September 26, 2023 19:42
@amcmanus amcmanus requested review from jonahkagan and removed request for a team September 26, 2023 19:42
Copy link
Contributor

@arsalansufi arsalansufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amcmanus amcmanus merged commit b0de844 into main Oct 2, 2023
@amcmanus amcmanus deleted the adam/trusted-build branch October 2, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants