[i18n-audio] Use 'audioID' naming instead of 'audioKey' #3989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kofi-q
requested review from
kshen0
and removed request for
a team and
kshen0
arsalansufi
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Follow-up from a discussion on #3987: updating the naming for audio clip IDs across the board to refer to
idinstead ofkeyfor consistency and clarity.Also expanded the field names for the
UiStringAudioCliptype to match the DB schema.Testing Plan
N/A
Checklist
[ ] I have added logging where appropriate to any new user actions, system updates such as file reads or storage writes, or errors introduced.[ ] I have added a screenshot and/or video to this PR to demo the change[ ] I have added the "user_facing_change" label to this PR to automate an announcement in #machine-product-updates