Migrate election primary precinct split fixture to use generated vers…

…ion (#5732) * remove original election file, switch export to generated * update libs/hmpb fixtures for primary with precinct splits * fix bug with election being save in different orders * add assert check to hmpb generate fixtures * clean up election pacakge export remove toElectionPackage * regenerate fixtures * update snapshot * update design be snapshots * tweak failure threshold * revert previous threshold change and regen snapshots * regen cvr fixtures off of generated election * fix issue with election json being reformatted * update generated election package fixtures * update fixtures prettier config * regen cvr fixtures * add comment based on pr comments * update comment on render ballot change * fix test
votingworks · Dec 12, 2024 · 970ce58 · 970ce58
1 parent 588ed0b
commit 970ce58
Show file tree

Hide file tree

Showing 1,894 changed files with 6,649 additions and 11,650 deletions.
diff --git a/apps/admin/backend/src/app.tally_report_data.test.ts b/apps/admin/backend/src/app.tally_report_data.test.ts
@@ -531,20 +531,20 @@ test('multi language, filtered by ballot style - grouped by precinct ', async ()
 
   expect(congressional1split1.cardCountsByParty).toEqual({
     '0': {
-      bmd: 72,
-      hmpb: [],
+      bmd: 0,
+      hmpb: [72],
     },
   });
   expect(congressional1split2.cardCountsByParty).toEqual({
     '0': {
-      bmd: 72,
-      hmpb: [],
+      bmd: 0,
+      hmpb: [72],
     },
   });
   expect(congressional2.cardCountsByParty).toEqual({
     '1': {
-      bmd: 72,
-      hmpb: [],
+      bmd: 0,
+      hmpb: [72],
     },
   });
 });
@@ -575,8 +575,8 @@ test('multi language, filtered by party - grouped by ballot style ', async () =>
     assert(report.hasPartySplits);
     expect(report.cardCountsByParty).toEqual({
       '0': {
-        bmd: report.ballotStyleGroupId === '1-Ma' ? 144 : 72,
-        hmpb: [],
+        bmd: 0,
+        hmpb: [report.ballotStyleGroupId === '1-Ma' ? 144 : 72],
       },
     });
   }
@@ -615,14 +615,14 @@ test('multi language, reports by ballot style - agnostic to language specific ba
   assert(fourthFishTallyReport.hasPartySplits);
   expect(firstMammalTallyReport.cardCountsByParty).toEqual({
     '0': {
-      bmd: 144,
-      hmpb: [],
+      bmd: 0,
+      hmpb: [144],
     },
   });
   expect(fourthFishTallyReport.cardCountsByParty).toEqual({
     '1': {
-      bmd: 72,
-      hmpb: [],
+      bmd: 0,
+      hmpb: [72],
     },
   });
   // contest lists should be different

diff --git a/...create-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-1-snap.png b/...create-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-1-snap.png
diff --git a/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-10-snap.png b/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-10-snap.png
diff --git a/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-11-snap.png b/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-11-snap.png
diff --git a/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-12-snap.png b/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-12-snap.png
diff --git a/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-13-snap.png b/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-13-snap.png
diff --git a/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-14-snap.png b/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-14-snap.png
diff --git a/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-15-snap.png b/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-15-snap.png
diff --git a/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-16-snap.png b/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-16-snap.png
diff --git a/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-17-snap.png b/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-17-snap.png
diff --git a/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-18-snap.png b/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-18-snap.png
diff --git a/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-19-snap.png b/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-19-snap.png
diff --git a/...create-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-2-snap.png b/...create-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-2-snap.png
diff --git a/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-20-snap.png b/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-20-snap.png
diff --git a/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-21-snap.png b/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-21-snap.png
diff --git a/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-22-snap.png b/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-22-snap.png
diff --git a/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-23-snap.png b/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-23-snap.png
diff --git a/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-24-snap.png b/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-24-snap.png
diff --git a/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-25-snap.png b/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-25-snap.png
diff --git a/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-26-snap.png b/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-26-snap.png
diff --git a/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-27-snap.png b/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-27-snap.png
diff --git a/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-28-snap.png b/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-28-snap.png
diff --git a/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-29-snap.png b/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-29-snap.png
diff --git a/...create-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-3-snap.png b/...create-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-3-snap.png
diff --git a/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-30-snap.png b/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-30-snap.png
diff --git a/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-31-snap.png b/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-31-snap.png
diff --git a/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-32-snap.png b/...reate-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-32-snap.png
diff --git a/...create-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-4-snap.png b/...create-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-4-snap.png
diff --git a/...create-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-5-snap.png b/...create-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-5-snap.png
diff --git a/...create-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-6-snap.png b/...create-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-6-snap.png
diff --git a/...create-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-7-snap.png b/...create-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-7-snap.png
diff --git a/...create-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-8-snap.png b/...create-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-8-snap.png
diff --git a/...create-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-9-snap.png b/...create-precinct-test-deck-for-a-precinct-with-multiple-ballot-styles-9-snap.png
diff --git a/...st-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-1-snap.png b/...st-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-1-snap.png
diff --git a/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-10-snap.png b/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-10-snap.png
diff --git a/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-11-snap.png b/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-11-snap.png
diff --git a/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-12-snap.png b/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-12-snap.png
diff --git a/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-13-snap.png b/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-13-snap.png
diff --git a/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-14-snap.png b/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-14-snap.png
diff --git a/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-15-snap.png b/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-15-snap.png
diff --git a/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-16-snap.png b/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-16-snap.png
diff --git a/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-17-snap.png b/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-17-snap.png
diff --git a/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-18-snap.png b/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-18-snap.png
diff --git a/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-19-snap.png b/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-19-snap.png
diff --git a/...st-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-2-snap.png b/...st-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-2-snap.png
diff --git a/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-20-snap.png b/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-20-snap.png
diff --git a/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-21-snap.png b/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-21-snap.png
diff --git a/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-22-snap.png b/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-22-snap.png
diff --git a/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-23-snap.png b/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-23-snap.png
diff --git a/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-24-snap.png b/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-24-snap.png
diff --git a/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-25-snap.png b/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-25-snap.png
diff --git a/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-26-snap.png b/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-26-snap.png
diff --git a/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-27-snap.png b/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-27-snap.png
diff --git a/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-28-snap.png b/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-28-snap.png
diff --git a/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-29-snap.png b/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-29-snap.png
diff --git a/...st-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-3-snap.png b/...st-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-3-snap.png
diff --git a/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-30-snap.png b/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-30-snap.png
diff --git a/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-31-snap.png b/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-31-snap.png
diff --git a/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-32-snap.png b/...t-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-32-snap.png
diff --git a/...st-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-4-snap.png b/...st-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-4-snap.png
diff --git a/...st-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-5-snap.png b/...st-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-5-snap.png
diff --git a/...st-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-6-snap.png b/...st-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-6-snap.png
diff --git a/...st-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-7-snap.png b/...st-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-7-snap.png
diff --git a/...st-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-8-snap.png b/...st-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-8-snap.png
diff --git a/...st-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-9-snap.png b/...st-ts-create-precinct-test-deck-for-a-precinct-with-one-ballot-style-9-snap.png
diff --git a/...__image_snapshots__/test-decks-test-ts-create-test-deck-tally-report-1-snap.png b/...__image_snapshots__/test-decks-test-ts-create-test-deck-tally-report-1-snap.png
diff --git a/...__image_snapshots__/test-decks-test-ts-create-test-deck-tally-report-2-snap.png b/...__image_snapshots__/test-decks-test-ts-create-test-deck-tally-report-2-snap.png
diff --git a/apps/design/backend/src/test_decks.test.ts b/apps/design/backend/src/test_decks.test.ts
@@ -64,9 +64,7 @@ describe('createPrecinctTestDeck', () => {
 
   test('for a precinct with multiple ballot styles', async () => {
     const fixtures = primaryElectionFixtures;
-    const primaryElectionDefinition = (
-      await readElection(fixtures.electionPath)
-    ).unsafeUnwrap();
+    const primaryElectionDefinition = fixtures.electionDefinition;
     // Test takes unnecessarily long if using all language ballot styles
     const electionDefinition: ElectionDefinition = {
       ...primaryElectionDefinition,
@@ -175,10 +173,7 @@ describe('getTallyReportResults', () => {
   });
 
   test('primary', async () => {
-    const fixtures = primaryElectionFixtures;
-    const electionDefinition = (
-      await readElection(fixtures.electionPath)
-    ).unsafeUnwrap();
+    const { electionDefinition } = primaryElectionFixtures;
     const { election } = electionDefinition;
 
     const tallyReportResults = await getTallyReportResults(election);
@@ -242,7 +237,5 @@ test('createTestDeckTallyReport', async () => {
     generatedAtTime: new Date('2021-01-01T00:00:00.000'),
   });
 
-  await expect(reportDocumentBuffer).toMatchPdfSnapshot({
-    failureThreshold: 0.0001,
-  });
+  await expect(reportDocumentBuffer).toMatchPdfSnapshot();
 });
diff --git a/...neral-election-letter-paper-language-en-marked-ballot-interpretation-1-snap.png b/...neral-election-letter-paper-language-en-marked-ballot-interpretation-1-snap.png
diff --git a/libs/ballot-interpreter/src/interpret_vx_hmpb.test.ts b/libs/ballot-interpreter/src/interpret_vx_hmpb.test.ts
@@ -387,11 +387,8 @@ for (const spec of generalElectionFixtures.fixtureSpecs) {
 }
 
 describe('HMPB - primary election', () => {
-  const { electionPath, mammalParty, fishParty } = primaryElectionFixtures;
-  let electionDefinition: ElectionDefinition;
-  beforeAll(async () => {
-    electionDefinition = (await readElection(electionPath)).unsafeUnwrap();
-  });
+  const { electionDefinition, mammalParty, fishParty } =
+    primaryElectionFixtures;
 
   for (const [partyLabel, partyFixtures] of Object.entries({
     mammalParty,

diff --git a/libs/fixture-generators/bin/generate-cvr-fixtures b/libs/fixture-generators/bin/generate-cvr-fixtures
@@ -11,7 +11,7 @@ rm -rf ../fixtures/data/electionTwoPartyPrimary/castVoteRecords/machine_0000__20
 ./bin/generate-cvrs --electionDefinition ../fixtures/data/electionTwoPartyPrimary/election.json --outputPath ../fixtures/data/electionTwoPartyPrimary/castVoteRecords/machine_0000__2024-01-01_00-00-00
 
 rm -rf ../fixtures/data/electionPrimaryPrecinctSplits/castVoteRecords/machine_0000__2024-01-01_00-00-00
-./bin/generate-cvrs --electionDefinition ../fixtures/data/electionPrimaryPrecinctSplits/election.json --outputPath ../fixtures/data/electionPrimaryPrecinctSplits/castVoteRecords/machine_0000__2024-01-01_00-00-00
+./bin/generate-cvrs --electionDefinition ../fixtures/data/electionPrimaryPrecinctSplits/electionGeneratedWithGridLayoutsMultiLang.json --outputPath ../fixtures/data/electionPrimaryPrecinctSplits/castVoteRecords/machine_0000__2024-01-01_00-00-00
 
 echo
 echo "Note: You need to run \`pnpm build:resources && pnpm build\` in libs/fixtures for the new fixtures to register"
diff --git a/libs/fixture-generators/src/generate-cvrs/generate_cvrs.ts b/libs/fixture-generators/src/generate-cvrs/generate_cvrs.ts
@@ -205,8 +205,7 @@ export function* generateCvrs({
   const { ballotStyles } = election;
 
   // Currently we can generate only BMD ballots for non-gridLayouts elections.
-  // For gridLayouts elections we can generate BMD ballots although it would
-  // not be realistic since they cannot currently be scanned.
+  // For gridLayouts elections we just generate HMPB ballots for simplicity but could generated BMD.
   const bmdBallots = Boolean(!election.gridLayouts);
 
   for (const ballotStyle of ballotStyles) {

diff --git a/libs/fixture-generators/src/generate-election-package/generate_election_package.test.ts b/libs/fixture-generators/src/generate-election-package/generate_election_package.test.ts
@@ -34,11 +34,11 @@ describe('fixtures are up to date - run `pnpm generate-election-packages` if thi
 
     const baseElection =
       electionPrimaryPrecinctSplitsFixtures.baseElection_DEPRECATED.election;
-    const electionFileContents =
-      electionPrimaryPrecinctSplitsFixtures.electionPackageExport.asBuffer();
-    const result = await readElectionPackageFromBuffer(electionFileContents);
-    assert(result.isOk());
-    const { electionPackage } = result.ok();
+    const { electionPackage } = (
+      await readElectionPackageFromBuffer(
+        electionPrimaryPrecinctSplitsFixtures.electionPackage.asBuffer()
+      )
+    ).unsafeUnwrap();
 
     const translator = new GoogleCloudTranslatorWithElectionCache({
       translationClient: mockTranslationClient,

diff --git a/libs/fixtures/.prettierignore b/libs/fixtures/.prettierignore
@@ -1 +1,3 @@
 /**/castVoteRecords/generated
+/data/**/castVoteRecords/
+/**/electionGenerated*.json
diff --git a/...ata/electionPrimaryPrecinctSplits/castVoteRecords/machine_0000__2024-01-01_00-00-00.vxsig b/...ata/electionPrimaryPrecinctSplits/castVoteRecords/machine_0000__2024-01-01_00-00-00.vxsig
diff --git a/...00__2024-01-01_00-00-00/0018de56-36eb-4a6d-9cbe-0261fadbeed3/cast-vote-record-report.json b/...00__2024-01-01_00-00-00/0018de56-36eb-4a6d-9cbe-0261fadbeed3/cast-vote-record-report.json