Don't set VX_MACHINE_TYPE within ScannerStore mocks

Since we might instantiate both a MockCentralScannerStore and a MockPrecinctScannerStore
votingworks · Oct 13, 2023 · 82fb427 · 82fb427
1 parent c1adcbb
commit 82fb427
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/libs/backend/src/cast_vote_records/export.test.ts b/libs/backend/src/cast_vote_records/export.test.ts
@@ -81,6 +81,9 @@ let mockUsbDrive: MockUsbDrive;
 let tempDirectoryPath: string;
 
 beforeEach(() => {
+  // While this should technically be set to "central-scan" for tests emulating VxCentralScan
+  // behavior, always using "scan" is fine for the purposes of these tests.
+  process.env['VX_MACHINE_TYPE'] = 'scan';
   mockFeatureFlagger.resetFeatureFlags();
 
   mockUsbDrive = createMockUsbDrive();

diff --git a/libs/backend/test/utils.ts b/libs/backend/test/utils.ts
@@ -108,12 +108,7 @@ class MockScannerStore implements ScannerStore {
 /**
  * A mock central scanner store
  */
-export class MockCentralScannerStore extends MockScannerStore {
-  constructor() {
-    super();
-    process.env['VX_MACHINE_TYPE'] = 'central-scan';
-  }
-}
+export class MockCentralScannerStore extends MockScannerStore {}
 
 /**
  * A mock precinct scanner store
@@ -126,7 +121,6 @@ export class MockPrecinctScannerStore extends MockScannerStore {
     super();
     this.exportDirectoryName = undefined;
     this.pollsState = 'polls_closed_initial';
-    process.env['VX_MACHINE_TYPE'] = 'scan';
   }
 
   getExportDirectoryName(): string | undefined {