Make sure saving backup on VxCentralScan doesn't crash app when no USB

Also clear error message on subsequent backup attempts
votingworks · Oct 6, 2023 · 4063b4f · 4063b4f
1 parent f5b1f7f
commit 4063b4f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/apps/central-scan/frontend/src/screens/admin_actions_screen.tsx b/apps/central-scan/frontend/src/screens/admin_actions_screen.tsx
@@ -96,6 +96,7 @@ export function AdminActionsScreen({
 
   function saveBackup() {
     setIsBackingUp(true);
+    setBackupError('');
     exportCastVoteRecordsToUsbDriveMutation.mutate(
       { isMinimalExport: false },
       {

diff --git a/libs/backend/src/cast_vote_records/export.ts b/libs/backend/src/cast_vote_records/export.ts
@@ -13,6 +13,7 @@ import {
 import {
   assert,
   assertDefined,
+  err,
   ok,
   Result,
   throwIllegalValue,
@@ -673,7 +674,9 @@ export async function exportCastVoteRecordsToUsbDrive(
         ? usbDriveStatus.mountPoint
         : undefined;
   }
-  assert(usbMountPoint !== undefined);
+  if (usbMountPoint === undefined) {
+    return err({ type: 'missing-usb-drive' });
+  }
   const exportContext: ExportContext = {
     exporter: new Exporter({
       allowedExportPatterns: SCAN_ALLOWED_EXPORT_PATTERNS,