Add .env.production file for flags toggled differently in prod vs. dev (

#5572)

* Get rid of unused env vars

* Update env var order to be consistent across files

* Add missing REACT_APP_VX_MARK_SCAN_USE_BMD_150 env var

* Add .env.production for flags toggled differently in prod vs. dev

.env

@@ -6,15 +6,15 @@ REACT_APP_VX_SKIP_PIN_ENTRY=FALSE
 REACT_APP_VX_USE_MOCK_CARDS=FALSE
 REACT_APP_VX_USE_MOCK_USB_DRIVE=FALSE
 REACT_APP_VX_USE_MOCK_PRINTER=FALSE
-REACT_APP_VX_USE_MOCK_PAPER_HANDLER=FALSE
-REACT_APP_VX_USE_BROTHER_PRINTER=FALSE
-REACT_APP_VX_USE_CUSTOM_SCANNER=FALSE
 REACT_APP_VX_SKIP_CVR_BALLOT_HASH_CHECK=FALSE
 REACT_APP_VX_SKIP_ELECTION_PACKAGE_AUTHENTICATION=FALSE
 REACT_APP_VX_SKIP_CAST_VOTE_RECORDS_AUTHENTICATION=FALSE
-REACT_APP_VX_DISABLE_BALLOT_BOX_CHECK=FALSE
-REACT_APP_VX_ENABLE_CLOUD_TRANSLATION_AND_SPEECH_SYNTHESIS=FALSE
 REACT_APP_VX_CONVERTER=ms-sems
+REACT_APP_VX_USE_MOCK_PAPER_HANDLER=FALSE
+REACT_APP_VX_MARK_SCAN_USE_BMD_150=TRUE
+REACT_APP_VX_ENABLE_CLOUD_TRANSLATION_AND_SPEECH_SYNTHESIS=FALSE
+REACT_APP_VX_USE_BROTHER_PRINTER=FALSE
+REACT_APP_VX_USE_CUSTOM_SCANNER=FALSE
 REACT_APP_VX_ONLY_ENABLE_SCREEN_READER_FOR_HEADPHONES=FALSE
 REACT_APP_VX_MARK_SCAN_DISABLE_BALLOT_REINSERTION=FALSE
 REACT_APP_VX_HIDE_CURSOR=FALSE

.env.production

@@ -0,0 +1,4 @@
+REACT_APP_VX_ENABLE_ALL_ZERO_SMARTCARD_PIN_GENERATION=FALSE
+REACT_APP_VX_ENABLE_DEV_DOCK=FALSE
+REACT_APP_VX_ONLY_ENABLE_SCREEN_READER_FOR_HEADPHONES=TRUE
+REACT_APP_VX_HIDE_CURSOR=TRUE

libs/utils/src/env.d.ts

@@ -14,13 +14,11 @@ declare namespace NodeJS {
     REACT_APP_VX_SKIP_CVR_BALLOT_HASH_CHECK?: string;
     REACT_APP_VX_SKIP_ELECTION_PACKAGE_AUTHENTICATION?: string;
     REACT_APP_VX_SKIP_CAST_VOTE_RECORDS_AUTHENTICATION?: string;
-    REACT_APP_VX_DISABLE_BALLOT_BOX_CHECK?: string;
+    REACT_APP_VX_CONVERTER?: string;
     REACT_APP_VX_USE_MOCK_PAPER_HANDLER?: string;
     REACT_APP_VX_MARK_SCAN_USE_BMD_150?: string;
     REACT_APP_VX_ENABLE_CLOUD_TRANSLATION_AND_SPEECH_SYNTHESIS?: string;
     REACT_APP_VX_USE_BROTHER_PRINTER?: string;
-    REACT_APP_VX_CONVERTER?: string;
-    REACT_APP_VX_SKIP_SYSTEM_AUDIO_SETUP?: string;
     REACT_APP_VX_USE_CUSTOM_SCANNER?: string;
     REACT_APP_VX_ONLY_ENABLE_SCREEN_READER_FOR_HEADPHONES?: string;
     REACT_APP_VX_MARK_SCAN_DISABLE_BALLOT_REINSERTION?: string;

libs/utils/src/environment_variable.ts

@@ -47,11 +47,6 @@ export enum BooleanEnvironmentVariableName {
    * Skips authentication (i.e. signature verification) of cast vote records on import
    */
   SKIP_CAST_VOTE_RECORDS_AUTHENTICATION = 'REACT_APP_VX_SKIP_CAST_VOTE_RECORDS_AUTHENTICATION',
-  /**
-   * Disables the ballot box check on VxMarkScan. If false, the app will block until the ballot
-   * box is attached
-   */
-  DISABLE_BALLOT_BOX_CHECK = 'REACT_APP_VX_DISABLE_BALLOT_BOX_CHECK',
   /**
    * Allows VxMarkScan to run without a connection to the Custom paper handler
    */
@@ -149,8 +144,6 @@ export function getEnvironmentVariable(
       return process.env.REACT_APP_VX_SKIP_CAST_VOTE_RECORDS_AUTHENTICATION;
     case StringEnvironmentVariableName.CONVERTER:
       return process.env.REACT_APP_VX_CONVERTER;
-    case BooleanEnvironmentVariableName.DISABLE_BALLOT_BOX_CHECK:
-      return process.env.REACT_APP_VX_DISABLE_BALLOT_BOX_CHECK;
     case BooleanEnvironmentVariableName.USE_MOCK_PAPER_HANDLER:
       return process.env.REACT_APP_VX_USE_MOCK_PAPER_HANDLER;
     case BooleanEnvironmentVariableName.MARK_SCAN_USE_BMD_150:
@@ -244,12 +237,6 @@ export function getBooleanEnvVarConfig(
         allowInProduction: false,
         autoEnableInDevelopment: false,
       };
-    case BooleanEnvironmentVariableName.DISABLE_BALLOT_BOX_CHECK:
-      return {
-        name,
-        allowInProduction: false,
-        autoEnableInDevelopment: true,
-      };
     case BooleanEnvironmentVariableName.USE_MOCK_PAPER_HANDLER:
       return {
         name,