Outwardly refer to VxMarkScan as VxMark and remove VxMark(Old) as option (and other minor cleanup) #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adghayes
approved these changes
Nov 12, 2024
benadida
approved these changes
Nov 12, 2024
|
Noting that, while I was at is, I also removed a no longer relevant vendor menu option (Reset System Authentication Code): 8a30d84 |
arsalansufi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link: votingworks/vxsuite#5588
Quite a while back, we decided to rename VxMarkScan VxMark and now think of the v2 VxMark deployed in Mississippi as VxMark(Old). We'll eventually come up with a better naming scheme and more fully rename things in code.
But before we submit v4 for cert, let's at least remove VxMark(Old) as an option in the
setup-machine.shscript and outwardly refer to VxMarkScan as VxMark.This will hopefully avoid some confusion during SLI Trusted Build.