Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate Exceptions from encryption code #424

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

JohnLCaron
Copy link
Collaborator

Eliminate Exceptions (mostly) from pre-encryption code.
ElectionRecordFactory.readElectionRecord validates the manifest, so AddEncryptedBallot doesnt have to.
AddEncryptedBallot uses the confirmationCode to track the pending ballots, so cant get an Exception on ccode.toHex().
Set opt-in compiler flags to reduce compiler noise

Eliminate Exceptions (mostly) from pre-encryption code.
ElectionRecordFactory.readElectionRecord validates the manifest, so AddEncryptedBallot doesnt have to.
AddEncryptedBallot uses the confirmationCode to track the pending ballots, so cant get an Exception on ccode.toHex().
Set opt-in compiler flags to reduce compiler noise.
Eliminate Exceptions (mostly) from pre-encryption code.
ElectionRecordFactory.readElectionRecord validates the manifest, so AddEncryptedBallot doesnt have to.
AddEncryptedBallot uses the confirmationCode to track the pending ballots, so cant get an Exception on ccode.toHex().
Set opt-in compiler flags to reduce compiler noise.
@JohnLCaron JohnLCaron merged commit c308003 into votingworks:main Nov 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant