-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
public-hoist all eslint packages (#3781)
I'd like to make our dependencies easier to understand. Currently, all of our package.json files reference a bunch of eslint configs and plugins that they don't explicitly use in their eslint configs. Why? Because they are referenced in eslint-plugin-vx and eslint is not able to resolve the packages if they're not in a flat node module structure (like npm). To replicate this with pnpm, we "publicly hoist" all eslint packages. This is the default config that pnpm now ships with. All publicly hoisted packages exist in a flat node modules directory at the root of the repo. My goal is two-fold: - make the package.json more informative by only including explicitly referenced packages - avoid drifting versions of eslint. there were places in the repo where we had upgraded plugin dependencies of eslint-plugin-vx but hadn't upgraded those plugins in other packages, meaning linting was not getting bug fixes / improvements in those packages as intended
- Loading branch information
Showing
50 changed files
with
125 additions
and
2,236 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -51,22 +51,12 @@ | |
| }, | ||
| "devDependencies": { | ||
| "@types/node": "16.18.23", | ||
| "@typescript-eslint/eslint-plugin": "5.37.0", | ||
| "@typescript-eslint/parser": "5.37.0", | ||
| "concurrently": "^7.6.0", | ||
| "eslint": "8.23.1", | ||
| "eslint-config-airbnb-base": "^14.2.1", | ||
| "eslint-config-prettier": "^8.5.0", | ||
| "eslint-import-resolver-node": "^0.3.4", | ||
| "eslint-plugin-cypress": "^2.12.1", | ||
| "eslint-plugin-import": "^2.26.0", | ||
| "eslint-plugin-jest": "^27.2.3", | ||
| "eslint-plugin-jsx-a11y": "^6.6.1", | ||
| "eslint-plugin-vx": "workspace:*", | ||
| "is-ci-cli": "^2.1.2", | ||
| "lint-staged": "^11.0.0", | ||
| "sort-package-json": "^1.50.0", | ||
| "typescript": "4.6.3" | ||
| "sort-package-json": "^1.50.0" | ||
| }, | ||
| "packageManager": "[email protected]" | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -51,22 +51,12 @@ | |
| "start-server-and-test": "^1.12.5" | ||
| }, | ||
| "devDependencies": { | ||
| "@typescript-eslint/eslint-plugin": "5.37.0", | ||
| "@typescript-eslint/parser": "5.37.0", | ||
| "concurrently": "^7.6.0", | ||
| "eslint": "8.23.1", | ||
| "eslint-config-airbnb-base": "^14.2.1", | ||
| "eslint-config-prettier": "^8.5.0", | ||
| "eslint-import-resolver-node": "^0.3.4", | ||
| "eslint-plugin-cypress": "^2.12.1", | ||
| "eslint-plugin-import": "^2.26.0", | ||
| "eslint-plugin-jest": "^27.2.3", | ||
| "eslint-plugin-jsx-a11y": "^6.6.1", | ||
| "eslint-plugin-vx": "workspace:*", | ||
| "is-ci-cli": "^2.1.2", | ||
| "lint-staged": "^10.5.4", | ||
| "sort-package-json": "^1.50.0", | ||
| "typescript": "4.6.3" | ||
| "sort-package-json": "^1.50.0" | ||
| }, | ||
| "packageManager": "[email protected]" | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -51,22 +51,12 @@ | |
| }, | ||
| "devDependencies": { | ||
| "@types/node": "16.18.23", | ||
| "@typescript-eslint/eslint-plugin": "5.37.0", | ||
| "@typescript-eslint/parser": "5.37.0", | ||
| "concurrently": "^7.6.0", | ||
| "eslint": "8.23.1", | ||
| "eslint-config-airbnb-base": "^14.2.1", | ||
| "eslint-config-prettier": "^8.5.0", | ||
| "eslint-import-resolver-node": "^0.3.4", | ||
| "eslint-plugin-cypress": "^2.12.1", | ||
| "eslint-plugin-import": "^2.26.0", | ||
| "eslint-plugin-jest": "^27.2.3", | ||
| "eslint-plugin-jsx-a11y": "^6.6.1", | ||
| "eslint-plugin-vx": "workspace:*", | ||
| "is-ci-cli": "^2.1.2", | ||
| "lint-staged": "^11.0.0", | ||
| "sort-package-json": "^1.50.0", | ||
| "typescript": "4.6.3" | ||
| "sort-package-json": "^1.50.0" | ||
| }, | ||
| "packageManager": "[email protected]" | ||
| } | ||
Oops, something went wrong.