Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QMMM on Kohn-Sham level #1100

Merged
merged 17 commits into from
Jan 17, 2024
Merged

QMMM on Kohn-Sham level #1100

merged 17 commits into from
Jan 17, 2024

Conversation

baumeier
Copy link
Member

Small change that allows to do QMMM with KS single-particle densities.

@baumeier
Copy link
Member Author

@votca-bot changelog: KS-QMMM for single-particle states

@baumeier baumeier marked this pull request as draft January 17, 2024 14:06
@baumeier
Copy link
Member Author

@votca-bot format

@baumeier baumeier marked this pull request as ready for review January 17, 2024 14:20
@baumeier baumeier requested a review from junghans January 17, 2024 14:37
@baumeier baumeier enabled auto-merge January 17, 2024 14:59
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6253d94) 7.0% compared to head (d58ac60) 7.0%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1100   +/-   ##
======================================
  Coverage     7.0%    7.0%           
======================================
  Files           4       4           
  Lines         683     683           
======================================
  Hits           48      48           
  Misses        635     635           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@baumeier baumeier merged commit 95011cc into master Jan 17, 2024
55 checks passed
@baumeier baumeier deleted the ksqmmm branch January 17, 2024 16:04
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Feb 4, 2024
https://build.opensuse.org/request/show/1143680
by user cjunghans + anag+factory
- Drop python3-espressomd testing dependency, revert once
  gh#espressomd/espresso#4856 is fixed.
- Dropped 1093.patch, merged upstream
  - fix links in README and doc ([gh#votca/votca#1091])
  - fix python shebang to python3 ([gh#votca/votca#1093])
  - Clean-up CI ([gh#votca/votca#1092], [gh#votca/votca#1095])
  - remove reference to old webpage ([gh#votca/votca#1094])
  - fix doc generation without pyxtp ([gh#votca/votca#1097])
  - Do not run gmx tests without libgromacs ([gh#votca/votca#1099])
  - KS-QMMM for single-particle states ([gh#votca/votca#1100])
  - Spin-orbitals from ORCA in QMMM ([gh#votca/votca#1101])
  - better unit test for DFT embedding ([gh#votca/votca#1102])
- Update to 2024
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Feb 7, 2024
https://build.opensuse.org/request/show/1143680
by user cjunghans + anag+factory
- Drop python3-espressomd testing dependency, revert once
  gh#espressomd/espresso#4856 is fixed.
- Dropped 1093.patch, merged upstream
  - fix links in README and doc ([gh#votca/votca#1091])
  - fix python shebang to python3 ([gh#votca/votca#1093])
  - Clean-up CI ([gh#votca/votca#1092], [gh#votca/votca#1095])
  - remove reference to old webpage ([gh#votca/votca#1094])
  - fix doc generation without pyxtp ([gh#votca/votca#1097])
  - Do not run gmx tests without libgromacs ([gh#votca/votca#1099])
  - KS-QMMM for single-particle states ([gh#votca/votca#1100])
  - Spin-orbitals from ORCA in QMMM ([gh#votca/votca#1101])
  - better unit test for DFT embedding ([gh#votca/votca#1102])
- Update to 2024
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Feb 7, 2024
https://build.opensuse.org/request/show/1143680
by user cjunghans + anag+factory
- Drop python3-espressomd testing dependency, revert once
  gh#espressomd/espresso#4856 is fixed.
- Dropped 1093.patch, merged upstream
  - fix links in README and doc ([gh#votca/votca#1091])
  - fix python shebang to python3 ([gh#votca/votca#1093])
  - Clean-up CI ([gh#votca/votca#1092], [gh#votca/votca#1095])
  - remove reference to old webpage ([gh#votca/votca#1094])
  - fix doc generation without pyxtp ([gh#votca/votca#1097])
  - Do not run gmx tests without libgromacs ([gh#votca/votca#1099])
  - KS-QMMM for single-particle states ([gh#votca/votca#1100])
  - Spin-orbitals from ORCA in QMMM ([gh#votca/votca#1101])
  - better unit test for DFT embedding ([gh#votca/votca#1102])
- Update to 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants