Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Stencil3d regression test #155

Merged
merged 4 commits into from
Jul 24, 2024
Merged

Conversation

JacobLevinson
Copy link
Contributor

Added stencil3d regression test, a 3D stencil test that is a good example of how to use the new kernel launch api with 3 dimensional grids and blocks. I also updated the gitignore to include *.cache to avoid clutter when doing git add -A after making changes and runningt tests.

Copy link
Contributor

@tinebp tinebp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not recommend adding to github since the build folder is user-defined.

@JacobLevinson
Copy link
Contributor Author

I do not recommend adding to github since the build folder is user-defined.

Do you mean I should remove the *.cache from the gitignore?

@JacobLevinson
Copy link
Contributor Author

Resolved merge conflict by removing the same test that master branch did

@tinebp
Copy link
Contributor

tinebp commented Jul 24, 2024

I take back my comment about *.cache, I didn't notice the .gitignore file was already in the repo.
This test is a great addition to Vortex codebase!

@JacobLevinson
Copy link
Contributor Author

I take back my comment about *.cache, I didn't notice the .gitignore file was already in the repo. This test is a great addition to Vortex codebase!

Great! When will it be merged in? Thanks!

@tinebp tinebp merged commit f4376e2 into vortexgpgpu:master Jul 24, 2024
15 checks passed
@tinebp
Copy link
Contributor

tinebp commented Jul 24, 2024

well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants