New options for NEGFC + minor bug fixes #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…assed, which triggers subtraction of the estimate of the companion from the cube before calculating mu and sigma
…double-PCA SADI mode
…gle binned flux estimate for the companion
…n rotation (delta_rot, source_xy and min_frames_pca now propagated)
…n rotation (delta_rot, source_xy and min_frames_pca now propagated)
… potential redundant arguments from dictionary
…w popped from dictionary to ensure non-duplication
…ble with all cases
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #652 +/- ##
=======================================
Coverage 62.28% 62.28%
=======================================
Files 11 11
Lines 928 928
=======================================
Hits 578 578
Misses 350 350 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.