-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring oop upgrades #585
Refactoring oop upgrades #585
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #585 +/- ##
==========================================
+ Coverage 63.69% 65.40% +1.71%
==========================================
Files 56 64 +8
Lines 12224 12626 +402
==========================================
+ Hits 7786 8258 +472
+ Misses 4438 4368 -70
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I don't really understand why the previous tests were cancelled, although it seems they work with 3.10 without any 3.10 support yet. I think it is safe to assume the tests would have been passed if not cancelled Edit : jobs on github workflow cannot last more than 6 hours, thus the fail on the first 3 versions but not for the last. It is possible that 3.10 is more efficient at executing the various tests in here, therefore staying under the 6 hour limit. |
Thanks a lot @Eixalde! |
PCA is still unstable and will be fixed in the very next branch, until then caution is advised when using its object