Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring oop upgrades #585

Merged
merged 24 commits into from
Apr 25, 2023

Conversation

Eixalde
Copy link
Contributor

@Eixalde Eixalde commented Apr 1, 2023

  • Added lots of support centered around objects (parameters management, object reusability, saving results, etc)
  • Regrouped all objects in a sub-folder 'objects'
  • Added tests for all of that new content
  • Included in-code typing documentation

PCA is still unstable and will be fixed in the very next branch, until then caution is advised when using its object

@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2023

Codecov Report

Merging #585 (c72d4ab) into master (3282af8) will increase coverage by 1.71%.
The diff coverage is 74.50%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #585      +/-   ##
==========================================
+ Coverage   63.69%   65.40%   +1.71%     
==========================================
  Files          56       64       +8     
  Lines       12224    12626     +402     
==========================================
+ Hits         7786     8258     +472     
+ Misses       4438     4368      -70     
Impacted Files Coverage Δ
vip_hci/invprob/paco.py 60.00% <46.15%> (+0.62%) ⬆️
vip_hci/psfsub/nmf_fullfr.py 67.86% <50.00%> (+7.14%) ⬆️
vip_hci/psfsub/pca_fullfr.py 59.77% <50.72%> (ø)
vip_hci/objects/pppca.py 51.97% <51.97%> (ø)
vip_hci/psfsub/pca_local.py 69.64% <58.97%> (ø)
vip_hci/psfsub/nmf_local.py 74.84% <74.29%> (+0.65%) ⬆️
vip_hci/objects/postproc.py 74.68% <74.68%> (ø)
vip_hci/psfsub/framediff.py 92.13% <85.71%> (-1.12%) ⬇️
vip_hci/objects/ppnmf.py 88.14% <88.14%> (ø)
vip_hci/objects/ppfmmf.py 94.59% <94.59%> (ø)
... and 7 more

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Eixalde
Copy link
Contributor Author

Eixalde commented Apr 2, 2023

I don't really understand why the previous tests were cancelled, although it seems they work with 3.10 without any 3.10 support yet. I think it is safe to assume the tests would have been passed if not cancelled

Edit : jobs on github workflow cannot last more than 6 hours, thus the fail on the first 3 versions but not for the last. It is possible that 3.10 is more efficient at executing the various tests in here, therefore staying under the 6 hour limit.

@VChristiaens VChristiaens merged commit 7d79ed4 into vortex-exoplanet:master Apr 25, 2023
@VChristiaens
Copy link
Contributor

Thanks a lot @Eixalde!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants