Update pyo3 to 0.22 #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vorner
reviewed
Jun 29, 2024
Closed
|
What do we do about old Python versions no longer building on newer MacOs ? |
This removes the `Clone` impl from `Py<T>` which we can work around by keeping the GIL a bit longer in `log`. I believe that this has little to no implication (or maybe a positive one actually due to the switch to `clone_ref`). However, this means that we have to remove `Clone` impl from `Logger`. All of this is still compatible with `0.21` but still a breaking change.
Probably disable them there. I've been ignoring it for a lack of time for a while… |
|
Published. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
Cloneimpl fromPy<T>which we can work around by keeping the GIL a bit longer inlog. I believe that this has little to no implication (or maybe a positive one actually due to the switch toclone_ref).However, this means that we have to remove
Cloneimpl fromLogger.All of this is still compatible with
0.21but still a breaking change.