Bump pyo3 minimal version #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not actively adding new features right now, so I don't think there's any reason to raise it further. I just wonder about one thing, if I should do it as 0.8.5 or as 0.9. Any opinions on that? |
|
Probably this needs to be 0.9 given it removes the ability for users to mix pyo3 0.14 with pyo3-log, though in practice I'd be surprised if there was anyone who actually still wants pyo3 0.14! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increases the PyO3 minimal version to 0.15 as I think it might help avoid an occasional bug we see reported in the PyO3 repo, see PyO3/pyo3#3509 (comment)
Potentially we could go higher than 0.15 depending on what compatibility you want to upkeep here.