fix: Modernize RCTBridgeModule import, for Swift-modules compatibility #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes several compilation errors with "Duplicate interface definition for class […]" when a project uses Expo 44+, which has Swift modules. I don't expect this to be a breaking change. Reportedly, it's safe to use #import <React/*.h> with React Native 40+; see comment linked below. This project already uses an import of that form. See the line #import <React/RCTUtils.h> in the same file changed in this commit. Details: expo/expo#15622 (comment)
|
thank you! :) |
chrisbobbe
added a commit
to chrisbobbe/zulip-mobile
that referenced
this pull request
Jul 14, 2022
chrisbobbe
added a commit
to chrisbobbe/zulip-mobile
that referenced
this pull request
Jul 23, 2022
chrisbobbe
added a commit
to chrisbobbe/zulip-mobile
that referenced
this pull request
Jul 25, 2022
chrisbobbe
added a commit
to chrisbobbe/zulip-mobile
that referenced
this pull request
Aug 12, 2022
chrisbobbe
added a commit
to chrisbobbe/zulip-mobile
that referenced
this pull request
Aug 31, 2022
gnprice
pushed a commit
to chrisbobbe/zulip-mobile
that referenced
this pull request
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes several compilation errors with "Duplicate interface
definition for class […]" when a project uses Expo 44+, which has
Swift modules.
I don't expect this to be a breaking change. Reportedly, it's safe
to use
#import <React/*.h>
with React Native 40+; see comment linked below. This project
already uses an import of that form. See the line
#import <React/RCTUtils.h>
in the same file changed in this commit.
Details:
expo/expo#15622 (comment)