Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor generic functions to use newly introduced Rust impl Trait arguments #81

Open
1 of 4 tasks
cipriancraciun opened this issue May 23, 2018 · 0 comments
Open
1 of 4 tasks

Refactor generic functions to use newly introduced Rust impl Trait arguments #81

cipriancraciun opened this issue May 23, 2018 · 0 comments
Assignees
@cipriancraciun
Labels
code-builtins code-evaluator refactoring
Milestone
Backlog

Comments

@cipriancraciun
Copy link
Member

cipriancraciun commented May 23, 2018 •
edited
Loading

Tasks

  • replace &[&Value] with &[impl AsRef<Value>];
  • refactor into a single const INPUTS_EMPTY;
  • refactor usage of vec_vec_to_ref (and related);
  • refactor comparison builtins to use impl Trait;
@cipriancraciun cipriancraciun added this to the Release 0.1.0 milestone May 23, 2018
@cipriancraciun cipriancraciun changed the title Refactor generic functions to use newly introduced Rust impl trait arguments Refactor generic functions to use newly introduced Rust impl Trait arguments May 23, 2018
cipriancraciun added a commit that referenced this issue May 23, 2018
@cipriancraciun
[rust] Refactor code to use impl Trait feature, by replacing `&[&Va…
22f4561 
…lue]` with `&[impl AsRef<Value>]` [#81]
@cipriancraciun cipriancraciun self-assigned this May 23, 2018
cipriancraciun added a commit that referenced this issue Jun 5, 2018
@cipriancraciun
[evaluator] Minor code fixups (of a temporary nature) [#81]
58fdbc3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cipriancraciun cipriancraciun

Labels
code-builtins code-evaluator refactoring
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
1 participant
@cipriancraciun