Frequent failures

[ef4]

This may not be the fault of this package, but I frequently lose a job to an HTTP 400 while running this action.

https://github.com/embroider-build/embroider/pull/1001/checks?check_run_id=3863504298

It's sporadic and it's not super common, but when you have enough jobs the chance of hitting it on any given workflow gets quite high.

Better logging of which HTTP request is failing might help, and maybe retry is appropriate.

[ef4]

I figured out how to enable more logging in this action, so that may help me identify which URL is getting the 400.

- uses: volta-cli/action@v1
  env:
    ACTIONS_STEP_DEBUG: true

Once I get some failures with the logging on I can see about retries.

[rwjblue]

#97 is an initial stab at helping out here, we should now have logging to tell us if the failures are happening in tc.downloadTool or in the actual downloading of node / yarn / etc.

I have a few more ideas to implement also:

• add caching for the entire $VOLTA_HOME (cache key would be the contents of package.json's volta property) -- this would basically be like what actions/setup-node does for the global yarn/npm package caches;
• properly wrap actions/setup-node so that we can avoid copy/pasta of their code (and lagging behind on the features they create -- this will give us nice yarn/npm caching (see also details in Use @action/cache to cache where possible #27)

[rwjblue]

#97 is published as volta-cli/[email protected] if anyone wants to give it a whirl...

[ef4]

https://github.com/embroider-build/embroider is now updated to v3, so we should hopefully see improvement from #97.

[rwjblue]

#101 should also help a bit here (released in v3.0.2). I was able to get to the bottom of at least one of the major causes of request failure that we were hitting.

[JamesHenry]

I have been receiving intermittent "could not unpack" errors on the lerna repo for some time now:

https://github.com/lerna/lerna/actions/runs/4500110940/jobs/7918811928?pr=3603

Volta error: Could not unpack Node v18.15.0

I recommend volta to everyone I interact with, it's so great for local usage. If we can somehow just resolve this weak link then it will basically be flawless in my eyes!

I'm going to try switching to the setup-node action for now because apparently it will check for volta.node in package.json these days

[marcneander]

I have been receiving intermittent "could not unpack" errors on the lerna repo for some time now:

https://github.com/lerna/lerna/actions/runs/4500110940/jobs/7918811928?pr=3603

Volta error: Could not unpack Node v18.15.0

I recommend volta to everyone I interact with, it's so great for local usage. If we can somehow just resolve this weak link then it will basically be flawless in my eyes!

I'm going to try switching to the setup-node action for now because apparently it will check for volta.node in package.json these days

We're getting the same issue since a few days ago.

[mekwall]

Volta error: Could not unpack Node v18.15.0

Same here. Any updates on this issue @rwjblue?

[alexandr2110pro]

We too.

[rwjblue]

FWIW, the Could not unpack Node issue is more likely to be an issue with volta itself than with this action (since at that point in the runtime, we are calling volta setup directly and the action isn't in the picture...)

[NullVoxPopuli]

I've been avoiding volta for C.I., since actions/setup-node supports reading the config, and explained here: https://github.com/wyvox/action-setup-pnpm/blob/main/action.yml#L130

[ef4]

The "could not unpack" issue that we continue to see is almost certainly a problem with @actions/tool-cache. It's not clear that this action is really using that cache correctly, as we never see it hit the cache, and overwhelming the network filesystem that backs the cache seems to be the likely cause of the failures we're seeing.

[korniychuk]

It still reproducible in 5%-10% workflow runs.