Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notice: extension is incompatible with webui 1.8, pending removel form extension index #206

Open
w-e-w opened this issue Mar 11, 2024 · 5 comments

Comments

@w-e-w
Copy link

w-e-w commented Mar 11, 2024

@volotat
Hi I'm am the maintainer of https://github.com/AUTOMATIC1111/stable-diffusion-webui-extensions

base on user report and my testing seems that this extension is critically incompatible with the current release of webui 1.8 and for my testing this is the case

webui 1.8 will crash will crash on launch with this extension enabled


I believe the root cause stems from the unorthodox initialization of scritps at

modules.scripts.scripts_current = modules.scripts.scripts_img2img
modules.scripts.scripts_img2img.initialize_scripts(is_img2img=True)

from my quick testing removeing at least two lines would allwo webui to launch and even will allow user to use SD-CN-Animation to operate at least partially, during operation image seems to generate but lots of exceptions are thrown mainly one's related to other extensions caused by this extension

earlier versions of web UI does not crash completely but still exhibits lots of similer issues


judging by the lack of activity I believe this extension is no longer maintained as such my intention is to remove the extension from extention index until it is fixed, or redirect the URL to a usable fork if exist

there is no update on the status of this extension I will remove it from index after 1 week
for now I will add a description on index informing user that this is no longer compatible
AUTOMATIC1111/stable-diffusion-webui-extensions@7f46c1d

if this extension is fixed in the future or if anyone is willing to continue maintaining a fork please contact so it can be relisted on the index


@1manfactory
Copy link

too bad.
it still works somehow, at least on windows ports. But it is only a matter of time until it will stop working.

@w-e-w
Copy link
Author

w-e-w commented Apr 12, 2024

too bad. it still works somehow, at least on windows ports. But it is only a matter of time until it will stop working.

is this still working on 1.8?

btw I haven't actually remove it from the index

@1manfactory
Copy link

1manfactory commented Apr 12, 2024 via email

@w-e-w
Copy link
Author

w-e-w commented Apr 12, 2024

TypeError: Script.post_sample() takes 10 positional arguments but 248

yeah I'd remember seeing something similar
irrc that it is one of the errors caused by this extension (even though you see that the error is triggered by a built-in extension)

this extension is implemented in a way that's very easily broken or would cause other things to break if there's any change in web UI

@1manfactory
Copy link

1manfactory commented Apr 14, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants