Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T018: Remove nbval check for complex cell output #304

Merged
merged 1 commit into from
Dec 28, 2022

Conversation

dominiquesydow
Copy link
Collaborator

@dominiquesydow dominiquesydow commented Dec 28, 2022

Description

T018 sometimes shows differing DoG URLs in cell output DataFrame-- remove the nbval check for this cell, as individual DataFrame values are tested below.

Todos

  • Remove nbval check

Status

  • Ready to go

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@dominiquesydow dominiquesydow self-assigned this Dec 28, 2022
@dominiquesydow dominiquesydow mentioned this pull request Dec 28, 2022
16 tasks
@dominiquesydow dominiquesydow linked an issue Dec 28, 2022 that may be closed by this pull request
@dominiquesydow dominiquesydow changed the base branch from master to base-ci-env-fix December 28, 2022 11:26
@dominiquesydow dominiquesydow merged commit 1bf68a4 into base-ci-env-fix Dec 28, 2022
@dominiquesydow dominiquesydow deleted the t018-dog-urls branch December 28, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

T018: Sometimes shows differing DoG URLs
1 participant