Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend PR template (for new talktorials) #276

Merged
merged 3 commits into from
Dec 5, 2022
Merged

Conversation

dominiquesydow
Copy link
Collaborator

@dominiquesydow dominiquesydow commented Oct 14, 2022

Description

We had a PR template tailored for refactoring talktorials; extend this template to be helpful when adding new talktorials or extending existing talktorials.

Todos

  • Update PR template with some details on added packages, data, etc.

Status

  • Ready to go

@dominiquesydow
Copy link
Collaborator Author

Hi @AndreaVolkamer, could you please check if I covered relevant PR template TODOs?

@gorostiolam and @jesperswillem, sharing this also with you already for your submissions.
Please let me know if you think something's missing or unclear, thank you!

Copy link
Member

@AndreaVolkamer AndreaVolkamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @dominiquesydow!

@dominiquesydow dominiquesydow added the documentation Update/fix documentation label Oct 31, 2022
@dominiquesydow dominiquesydow merged commit 56a596f into master Dec 5, 2022
@dominiquesydow dominiquesydow deleted the ds-pr-template branch December 5, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Update/fix documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants