Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI failures #222

Merged
merged 6 commits into from
Mar 29, 2022
Merged

Fix CI failures #222

merged 6 commits into from
Mar 29, 2022

Conversation

schallerdavid
Copy link
Collaborator

@schallerdavid schallerdavid commented Mar 29, 2022

Description

This PR aims to fix CI failures involving RDKit installation on MacOS and T018 with failing API request of DogSiteScorer.

Todos

  • fix RDKit installation on MacOS (pin fontconfig)
  • fix T018 with failing API requests of DogSiteScorer
  • fix tensorflow AttributeError only seen for MacOS 44467 (pin h5py)
  • seeing dead nb kernel for MacOS

Status

  • Ready to go

@schallerdavid
Copy link
Collaborator Author

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@schallerdavid
Copy link
Collaborator Author

Python 3.7 succeeded for f7869fd. However, the other versions failed for various reasons including MacOS with an error related to tensorflow. I pushed a new commit pinning the h5py version, but now GitHub actions got stuck. I gotta take care of a presentation now and will check later.

@schallerdavid
Copy link
Collaborator Author

I added two NBVAL_SKIP statements to the cells in T018 doing requests for the dogsitescorer api based on an uploaded PDB structure. This seems to fail currently, maybe that's temporary, maybe for a longer time period, but it's likely a problem from protein.plus.

@schallerdavid
Copy link
Collaborator Author

The nb kernel dies on MacOS for some reason, letting it rerun to see if it only happens occasionally.

@schallerdavid
Copy link
Collaborator Author

Btw, I also played with multiprocessing of nbval for KinoML. I often got more stable runs, when only using a single process.

@schallerdavid
Copy link
Collaborator Author

So all tests pass 🎉, I will merge now to get the CI working in master, but it is very concerning that different CI runs fail for different reasons. I will open an issue tomorrow, so we dont forget to investigate this.

@schallerdavid schallerdavid merged commit db22f8b into master Mar 29, 2022
@schallerdavid schallerdavid deleted the ci_failures branch March 29, 2022 20:14
@dominiquesydow dominiquesydow mentioned this pull request Jul 22, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant