-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pandas failure #206
Fix pandas failure #206
Conversation
Hey @dominiquesydow and @t-kimber , I think I found the issue. It is about changes to PandasTools with the new RDKit release. However, I am having a hard time getting all CI runs green. It's mostly about a connection problem when requesting data online. This is completely random across the different Python versions and operating systems tested. Did you also observe such behavior recently? |
Hi @schallerdavid, thank you for the fix!! Could you please raise an issue that reminds us to un-pin Regarding the connection problems - I started to collect frequent trouble-makers here to address them in one go in a separate PR: For this PR, let's merge even if we have the usual connection CI problems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go from my side, thank you!
…into pandas_issue
@dominiquesydow I can't merge without all tests passing. Do you have such power :) ? I will give it a few more attempts. |
Hi @schallerdavid , don't you have this option ?
|
I have the power :) I will merge now (the tests will rerun anyways after the merge, no need to wait). |
Ohh, just saw you merged something, maybe it was for this reason. |
@schallerdavid - I just checked, @t-kimber is right, you are an admin according to TOC's GH settings; so you can merge with admin rights in the future. You have the power, too :) |
Description
This PR investigates recent failures of the CI when using the PandasTools from RDKit (#204).
Todos
Status