Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix crd to support job patch ops #786

Merged
merged 2 commits into from
Apr 30, 2020
Merged

fix crd to support job patch ops #786

merged 2 commits into from
Apr 30, 2020

Conversation

hzxuzhonghu
Copy link
Collaborator

Without this, when running kubectl edit vcjob xxx to update a job fails.

@hzxuzhonghu hzxuzhonghu changed the title fix crd to support fix crd to support patch ops Apr 30, 2020
@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 30, 2020
@hzxuzhonghu hzxuzhonghu changed the title fix crd to support patch ops fix crd to support job patch ops Apr 30, 2020
@k82cn
Copy link
Member

k82cn commented Apr 30, 2020

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2020
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu, k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2020
@volcano-sh-bot volcano-sh-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 30, 2020
@k82cn
Copy link
Member

k82cn commented Apr 30, 2020

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2020
@volcano-sh-bot volcano-sh-bot merged commit 36cffca into volcano-sh:master Apr 30, 2020
@TravisBuddy
Copy link

Travis tests have failed

Hey @hzxuzhonghu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 7e9fdf00-8abd-11ea-b0c3-9bf8056a98a6

@hzxuzhonghu hzxuzhonghu deleted the fic-crd branch May 6, 2020 01:58
@hzxuzhonghu hzxuzhonghu mentioned this pull request May 8, 2020
Merged
volcano-sh-bot added a commit that referenced this pull request May 8, 2020
@volcano-sh-bot
Merge pull request #794 from hzxuzhonghu/automated-cherry-pick-of-#78…
2275754 
…6-origin-release-0.4

Automated cherry pick of #786: Fix Job crd definition to support job patch
@hzxuzhonghu hzxuzhonghu mentioned this pull request Jul 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k82cn k82cn Awaiting requested review from k82cn

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

Assignees

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hzxuzhonghu @k82cn @volcano-sh-bot @TravisBuddy