Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update admission to use pflag. #567

Merged
merged 1 commit into from
Nov 28, 2019
Merged

Update admission to use pflag. #567

merged 1 commit into from
Nov 28, 2019

Conversation

k82cn
Copy link
Member

@k82cn k82cn commented Nov 27, 2019

Signed-off-by: Klaus Ma [email protected]

fixes: #553

@TravisBuddy
Copy link

Travis tests have failed

Hey @k82cn,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 4d1163d0-1107-11ea-b8ff-d5ab8a371226

@volcano-sh-bot volcano-sh-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 27, 2019
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2019
@k82cn k82cn added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2019
@TravisBuddy
Copy link

Hey @k82cn,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 41e42d80-1120-11ea-b8ff-d5ab8a371226

@TravisBuddy
Copy link

Hey @k82cn,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 83628900-1120-11ea-b8ff-d5ab8a371226

@TravisBuddy
Copy link

Hey @k82cn,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 0e3308c0-1121-11ea-b8ff-d5ab8a371226

@k82cn k82cn merged commit 80d8432 into volcano-sh:master Nov 28, 2019
@k82cn k82cn deleted the vc_553 branch November 28, 2019 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the parameter of vc-admission to start with --
3 participants