Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable more linter checks #792

Closed
hzxuzhonghu opened this issue May 8, 2020 · 6 comments · Fixed by #799
Closed

Enable more linter checks #792

hzxuzhonghu opened this issue May 8, 2020 · 6 comments · Fixed by #799
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@hzxuzhonghu
Copy link
Collaborator

We should introduce https://github.com/golangci/golangci-lint to make volcano better.

I donot think i have enough bandwidth, if anyone interested, please feel free to take over.

@hzxuzhonghu hzxuzhonghu added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels May 8, 2020
masihtehrani added a commit to masihtehrani/volcano that referenced this issue May 8, 2020
@masihtehrani
Copy link
Contributor

We should introduce https://github.com/golangci/golangci-lint to make volcano better.

I donot think i have enough bandwidth, if anyone interested, please feel free to take over.

I added Golangci-lit to the project you can use with make lint.
I fix some lint but it needed help to fix the whole project.

@hzxuzhonghu
Copy link
Collaborator Author

@masihtehrani Thanks, IMO, We can split the golangci-lint into several prs according to packages.

And ignore the others, after all fixes done, we can enable check on all pkgs/files

masihtehrani added a commit to masihtehrani/volcano that referenced this issue May 10, 2020
@masihtehrani
Copy link
Contributor

@masihtehrani Thanks, IMO, We can split the golangci-lint into several prs according to packages.

And ignore the others, after all fixes done, we can enable check on all pkgs/files

I added make lint just for two small pkg kube & version & first big package apis
just run with make lint
I don't add in Travis

masihtehrani added a commit to masihtehrani/volcano that referenced this issue May 10, 2020
@hzxuzhonghu hzxuzhonghu reopened this May 11, 2020
@hzxuzhonghu
Copy link
Collaborator Author

Thanks, we need to cover the whole project

carmark pushed a commit to carmark/volcano that referenced this issue Jul 14, 2020
@stale
Copy link

stale bot commented Aug 18, 2020

Hello 👋 Looks like there was no activity on this issue for last 90 days.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity for 60 days, this issue will be closed (we can always reopen an issue if we need!).

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 18, 2020
@stale
Copy link

stale bot commented Oct 17, 2020

Closing for now as there was no activity for last 60 days after marked as stale, let us know if you need this to be reopened! 🤗

@stale stale bot closed this as completed Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants