Skip to content
This repository has been archived by the owner on Aug 5, 2019. It is now read-only.

Commit

Permalink
Merge pull request #48 from jrit/master
Browse files Browse the repository at this point in the history
Fix svg_sprite, Improvements on notifications
  • Loading branch information
dmaloneycalu committed Feb 11, 2016
2 parents 56470c3 + b7c65bb commit f421ce0
Show file tree
Hide file tree
Showing 7 changed files with 23 additions and 10 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@

## Changelog


#### 6.1.1 Bug Fixes, Dep Updates

- Fixes svg_sprite task, updates peer dep as well
- Includes package name in email and Slack notifications

#### 6.1.0 Add Slack channel notifications

This is not included in deployment by default in this release, so to use, after deployment runs:
Expand Down
1 change: 1 addition & 0 deletions grunt/aliases.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ build:
- less
- ngtemplates
- copy
- svg_sprite
- browserify:build

pretest:
Expand Down
4 changes: 2 additions & 2 deletions grunt/jshint.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
"use strict";

module.exports = function ()
{
"use strict";

return {
dev: {
options: {
Expand Down
8 changes: 5 additions & 3 deletions grunt/notification.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ module.exports = function ( grunt )
{
var envConfig = grunt.config( "env" );
var deployVersion = grunt.config( "version" );
var pkgVersion = grunt.file.readJSON( "package.json" ).version || "";
var pkg = grunt.file.readJSON( "package.json" );
var pkgVersion = pkg.version || "";
var pkgName = pkg.name || "App";

grunt.registerTask( "notification", "Notify an email that a deployment is going out", function ()
{
Expand Down Expand Up @@ -36,13 +38,13 @@ module.exports = function ( grunt )
Message: {
Body: {
Html: {
Data: "<h1>Version " + pkgVersion + " @" + deployVersion + "</h1>"
Data: "<h1>" + pkgName + " build " + pkgVersion + " @" + deployVersion + "</h1>"
+ '<p>A new build for <a href="' + host + '">' + host + "</a> "
+ "should be available in about 10 minutes.</p>"
}
},
Subject: {
Data: "New build for " + host + " @" + deployVersion
Data: pkgName + " build for " + host + " @" + deployVersion
}
},
Source: emailFrom
Expand Down
6 changes: 4 additions & 2 deletions grunt/notification_slack.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ module.exports = function ( grunt )
var envConfig = grunt.config( "env" );
var slackApiToken = grunt.config( "slackApiToken" );
var deployVersion = grunt.config( "version" );
var pkgVersion = grunt.file.readJSON( "package.json" ).version || "";
var pkg = grunt.file.readJSON( "package.json" );
var pkgVersion = pkg.version || "";
var pkgName = pkg.name || "App";

grunt.registerTask( "notification_slack", "Notify a Slack channel that a deployment is going out", function ()
{
Expand All @@ -26,7 +28,7 @@ module.exports = function ( grunt )
var slacker = new Slack( slackApiToken );

slacker.api( "chat.postMessage", {
text: "Build " + pkgVersion + " @" + deployVersion + " for " + host
text: pkgName + " build " + pkgVersion + " @" + deployVersion + " for " + host
+ " should be available in about 10 minutes.",
channel: slackChannel,
username: "Release Bot"
Expand Down
4 changes: 3 additions & 1 deletion grunt/svg_sprite.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"use strict";

module.exports = {
css: {
expand: true,
Expand Down Expand Up @@ -33,8 +35,8 @@ module.exports = {

options: {
mode: {
inline: true,
symbol: {
inline: true,
sprite: "sprite.svg"
}
}
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "dominatr-grunt",
"version": "6.1.0",
"version": "6.1.1",
"description": "Build all the things!",
"scripts": {
"test": ""
Expand Down Expand Up @@ -40,7 +40,7 @@
"grunt-newer": "^1.1.1",
"grunt-postcss": "^0.7.1",
"grunt-protractor-coverage": "github:mdasberg/grunt-protractor-coverage#ef6a8fb",
"grunt-svg-sprite": "^1.2.15",
"grunt-svg-sprite": "github:vokal/grunt-svg-sprite.git#8200979a0e",
"grunt-svgmin": "^3.1.0",
"grunt-truecolors-less": "1.0.x",
"jasmine-bail-fast": "0.0.1",
Expand Down

0 comments on commit f421ce0

Please sign in to comment.