chore(deps,js): move to jupyterlab-manager 0.40 #153
Conversation
| @@ -8,7 +8,7 @@ | |||
| "@jupyter-widgets/base": "^1.2.2", | |||
| "@jupyter-widgets/controls": "^1.4.2", | |||
| "@jupyter-widgets/html-manager": "^0.15.2", | |||
| "@jupyter-widgets/jupyterlab-manager": "^0.39.1", | |||
| "@jupyter-widgets/jupyterlab-manager": "^0.40.0", | |||
There was a problem hiding this comment.
you probably need to update html-manager to 0.16 then?
There was a problem hiding this comment.
Good question. I thought html-manager was not a dependency anymore, but it is, only for the requireLoader
https://github.com/QuantStack/voila/blob/ab241427955d6dd917e74962d6365937f9c3fffe/js/src/manager.js#L10
So it's fine I think. I'd rather see that requireLoader go into main.js, and it being an argument of the widget manager, so also this part is pluggable.
There was a problem hiding this comment.
Yeah, sorry for a minute I thought that html-manager depended on jupyterlab-manager.
maartenbreddels
changed the title
maartenbreddels
changed the title
|
Travis failure: The bundle is now so large, it refuses to build with source mapping. Locally I had to disable source mapping to build it. |
😒 |
|
bumping jupyterlab-manager increases the size of the bundle so much? |
|
I'm exploring what is happening now using https://www.npmjs.com/package/webpack-bundle-analyzer |
|
It seems that bumping the manager adds +10MB in from jupyterlab, why that happens, I am not sure yet. The bundle is now ~25mb instead of ~5mb. |
|
Fixed in #277 |
Change in jupyter-widgets/ipywidgets#2265 caused voila to break, as noted by @SylvainCorlay.
In order to test if jupyter-widgets/ipywidgets#2418 works in voila, we first need to move to manager 0.40.