-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow moving folders to trash rather than completely deleting them #60
Comments
Nice idea! Maybe even a key combination with Del to send them there. We raise these questions in case anyone reading this has a broader knowledge on the subject. |
|
I'll take a look at integrating these two things together |
The Trash project is using some ESModule formatting which is making it infeasible to simply integrate this code. A lot of the library logic is relatively straightforward, but the dependencies themselves are ESModules so I got a bit stuck. |
Okay I think after reviewing a developer help guide and an open ts-node issue I'm on the right track. It does require some refactoring in this project, but I hope to have a PR ready soon. |
The 'trash' NPM package is added This dependency uses ESModule, requiring project refactoring Fixes voidcosmos#60
Instead of
rm
-ing the folders when a delete is triggered, it would be helpful to have an option that trashes them instead such as--trash
. This is much safer and reversible.The text was updated successfully, but these errors were encountered: