Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redshift: patch for wayland, AppArmor #9909

Closed
wants to merge 1 commit into from

Conversation

CameronNemo
Copy link
Contributor

I like to think there is a little something for everybody in here.

@CameronNemo CameronNemo changed the title redshift: patch for wayland, enable AppArmor redshift: patch for wayland, AppArmor Mar 16, 2019
@maxice8
Copy link
Contributor

maxice8 commented Mar 16, 2019

With that it will work on all wayland wlroots compositors and ones that support the same protocol ?

@CameronNemo
Copy link
Contributor Author

Yes indeed! See jonls/redshift#704

@maxice8
Copy link
Contributor

maxice8 commented Mar 16, 2019 via email

@Cogitri
Copy link
Contributor

Cogitri commented Mar 16, 2019

Why not wait for upstream to merge this?

Edit: Nvm, I guess this is for people who are interested in trying it now?

@CameronNemo
Copy link
Contributor Author

@Cogitri yeah, not sure when upstream is going to merge and release, figured people may be interested considering that sway 1.0 is out.

@Cogitri
Copy link
Contributor

Cogitri commented Mar 16, 2019

Ah, alright

@ericonr
Copy link
Member

ericonr commented May 11, 2020

Heh, thanks for the patch! Do you think we could talk to this guy https://github.com/minus7/redshift/tree/wayland about releasing a version in their repo? It'd be great to have that actually packaged.

@CameronNemo
Copy link
Contributor Author

I have actually been thinking about forking. I have merged quite a few fixes into this branch https://github.com/CameronNemo/redshift/commits/master

@ericonr
Copy link
Member

ericonr commented May 11, 2020

Are all of those fixes integrated into the current template?

@CameronNemo
Copy link
Contributor Author

Not at all. Current template is unpatched.

@jnbr
Copy link
Contributor

jnbr commented Jun 16, 2020

I'm against adding patches adding functionality.

I have actually been thinking about forking.

If upstream isn't accepting your patches or is not moving at all, please do so.
Adding large amount of patches into void-packages is not sustainable in the long term.

@ericonr
Copy link
Member

ericonr commented Jul 10, 2020

@CameronNemo if you do fork it and have a definitive template for it, add /etc/apparmor.d/local/usr.bin.redshift as a conf_files.

@CameronNemo
Copy link
Contributor Author

CameronNemo commented Jul 27, 2020

#23643

@CameronNemo CameronNemo deleted the redshift-wayland branch September 21, 2020 00:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants