Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error alerts are wrong #893

Closed
elboletaire opened this issue Dec 20, 2024 · 1 comment · Fixed by #976
Closed

Error alerts are wrong #893

elboletaire opened this issue Dec 20, 2024 · 1 comment · Fixed by #976
Assignees
@gerouvi

Comments

@elboletaire
Copy link
Member

elboletaire commented Dec 20, 2024 •
edited
Loading

I don't think error alerts should be this radioactive-green.

imatge
imatge

Success shouldn't be this green either
imatge

Actually, the icon used may be different than the one in the design. We're using a filled icon, but the design uses one which isn't filled. Try to search and use that instead.
@elboletaire elboletaire mentioned this issue Dec 20, 2024
Closed
11 tasks
@jpaulet jpaulet mentioned this issue Jan 7, 2025
Closed
17 tasks
@jpaulet jpaulet closed this as completed Feb 3, 2025
@jpaulet jpaulet reopened this Feb 3, 2025
gerouvi added a commit that referenced this issue Feb 3, 2025
@gerouvi
changed alert success green, icon centred and gap between icon and te…
d01093e 
…xt, closes #893
@gerouvi gerouvi mentioned this issue Feb 3, 2025
Merged
@jpaulet
Copy link
Member

jpaulet commented Feb 4, 2025

The PR: #976 closes this one.

@jpaulet jpaulet closed this as completed Feb 4, 2025
elboletaire added a commit that referenced this issue Feb 4, 2025
@elboletaire
refs #893 There's no need for a wrapping box...
d478a46
elboletaire added a commit that referenced this issue Feb 4, 2025
@gerouvi @elboletaire
fix: Alert icon spacing (#976)
9cfcf72 
* changed alert success green, icon centred and gap between icon and text, closes #893

* refs #893 There's no need for a wrapping box...

---------

Co-authored-by: Òscar Casajuana <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gerouvi gerouvi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Alert Icon vocdoni/ui-scaffold
3 participants
@elboletaire @jpaulet @gerouvi