Docker compose labels #8581
Closed
Docker compose labels #8581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After make a new network bridge network, the port mapping for containers which uses this new network will be lost after the VCH is rebooted from VC. And the iptables for the port mapping in VCH are also lost.
With traditional docker, the network created by docker-compose
contains labels property with empty object {}. But in VIC, labels
will be set to NULL. This error is only found when docker-compose
version is 2.0.
Codecov Report
@@ Coverage Diff @@
## master #8581 +/- ##
==========================================
- Coverage 31.4% 31.37% -0.03%
==========================================
Files 293 293
Lines 44376 44379 +3
==========================================
- Hits 13937 13926 -11
- Misses 29220 29235 +15
+ Partials 1219 1218 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6405
[specific ci=3-01-Docker-Compose]